Phil Sutter <phil@xxxxxx> wrote: > #include <string.h> > #include <stdlib.h> > +#include <libmnl/libmnl.h> Why is this include needed? > #include <libnftnl/common.h> > > #include "config.h" > @@ -83,4 +84,7 @@ int nftnl_fprintf(FILE *fpconst, const void *obj, uint32_t cmd, uint32_t type, > int nftnl_set_str_attr(const char **dptr, uint32_t *flags, > uint16_t attr, const void *data, uint32_t data_len); > > +void mnl_attr_put_ifname(struct nlmsghdr *nlh, int attr, const char *ifname); > +const char *mnl_attr_get_ifname(struct nlattr *attr); > + nftnl_attr_put_ifname, nftnl_attr_get_ifname? Using mnl_ prefix seems wrong, that should be reserved for libmnl.