Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> wrote: > diff --git a/tools/testing/selftests/net/netfilter/config b/tools/testing/selftests/net/netfilter/config > index c981d2a38ed68..79d5b33966ba1 100644 > --- a/tools/testing/selftests/net/netfilter/config > +++ b/tools/testing/selftests/net/netfilter/config > @@ -97,4 +97,4 @@ CONFIG_XFRM_STATISTICS=y > CONFIG_NET_PKTGEN=m > CONFIG_TUN=m > CONFIG_INET_DIAG=m > -CONFIG_SCTP_DIAG=m > +CONFIG_INET_SCTP_DIAG=m > diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config > index db176fe7d0c3f..8e902f7f1a181 100644 > --- a/tools/testing/selftests/tc-testing/config > +++ b/tools/testing/selftests/tc-testing/config > @@ -21,6 +21,7 @@ CONFIG_NF_NAT=m > CONFIG_NETFILTER_XT_TARGET_LOG=m > > CONFIG_NET_SCHED=y > +CONFIG_IP_SET=m > > # > # Queueing/Scheduling > > The CONFIG_SCTP_DIAG switch probably never existed. > tc-testing asks for NET_EMATCH_IPSET but this one always required > IP_SET. We can either remove them or fix them as suggested. > Preferences? Fix them as suggested. > > I suspect that it would make sense to split the config tweaks into > > a distinct patch, however. > > I can split the config tweaks out of it if you want. That would be my preference, will also help to root-cause in case something breaks. > If we are not making the legacy bits default, because we want to get rid > of them eventually, and therefore we fix the configs for the testsuite: > What about those under arch/*/configs? I don't see many changes to those, so looks like they can be left alone.
