On 2025-06-27 16:17:19 [+0200], Florian Westphal wrote: > So some of the problems with CI pipelines are caused by 'config' > settings having something like: > > IP_NF_TARGET_TTL=m > > ... but if you look at net/ipv4/netfilter/Kconfig this is: > config IP_NF_TARGET_TTL > tristate '"TTL" target support' > depends on NETFILTER_ADVANCED && IP_NF_MANGLE > select NETFILTER_XT_TARGET_HL > help > This is a backwards-compatible option for the user's convenience > (e.g. when running oldconfig). It selects > CONFIG_NETFILTER_XT_TARGET_HL. > > ... and that doesn't do anything anymore due to IP_NF_MANGLE dependency > (thats a legacy thing, so it will be off). > > So my plan was to zap those old backwards hints first and update > the configs to make sure none of the old symbols remain. Oh. > OTOH one could just add the correct config settings. > > I need to re-test but the attached updated patch should not omit any > of the required features even with legacy=n at least for the net ci. I tested the defconfig + the individual config file from tools/testing/selftests/ and compared the results from -rc4 vs -rc4 and the patch. Additionally checked defconfig + kselftest-merge. I don't see any "missing" options which are NF related with this patch now. Two options were always missing: diff --git a/tools/testing/selftests/net/netfilter/config b/tools/testing/selftests/net/netfilter/config index c981d2a38ed68..79d5b33966ba1 100644 --- a/tools/testing/selftests/net/netfilter/config +++ b/tools/testing/selftests/net/netfilter/config @@ -97,4 +97,4 @@ CONFIG_XFRM_STATISTICS=y CONFIG_NET_PKTGEN=m CONFIG_TUN=m CONFIG_INET_DIAG=m -CONFIG_SCTP_DIAG=m +CONFIG_INET_SCTP_DIAG=m diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config index db176fe7d0c3f..8e902f7f1a181 100644 --- a/tools/testing/selftests/tc-testing/config +++ b/tools/testing/selftests/tc-testing/config @@ -21,6 +21,7 @@ CONFIG_NF_NAT=m CONFIG_NETFILTER_XT_TARGET_LOG=m CONFIG_NET_SCHED=y +CONFIG_IP_SET=m # # Queueing/Scheduling The CONFIG_SCTP_DIAG switch probably never existed. tc-testing asks for NET_EMATCH_IPSET but this one always required IP_SET. We can either remove them or fix them as suggested. Preferences? > I suspect that it would make sense to split the config tweaks into > a distinct patch, however. I can split the config tweaks out of it if you want. > If you have cycles please feel free to work on it, I can most likey > not get back to it until 2nd week of July. If we are not making the legacy bits default, because we want to get rid of them eventually, and therefore we fix the configs for the testsuite: What about those under arch/*/configs? Sebastian
