On Tue, Jun 10, 2025 at 03:32:35PM +0200, Christoph Hellwig wrote:
> On Tue, Jun 10, 2025 at 09:56:04AM +0200, Carlos Maiolino wrote:
> > > - if (shadow->lv_buf_len == XFS_LOG_VEC_ORDERED)
> > > - ordered = true;
> > > + if (shadow->lv_buf_len == XFS_LOG_VEC_ORDERED) {
> > > + if (!lv) {
> > > + lv = shadow;
> > > + lv->lv_item = lip;
> > > + }
> > > + ASSERT(shadow->lv_size == lv->lv_size);
> >
> > This assert is kind of confusing me. if we have an
> > ORDERED vector here, couldn't we still have a shadow
> > size smaller than the current vector?
>
> The size of ordered items never changes, it's always the same constant
> overhead.
>
Fair enough, thanks:
Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
