Re: [PATCH 02/17] xfs: cleanup the ordered item logic in xlog_cil_insert_format_items

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 10, 2025 at 09:56:04AM +0200, Carlos Maiolino wrote:
> > -		if (shadow->lv_buf_len == XFS_LOG_VEC_ORDERED)
> > -			ordered = true;
> > +		if (shadow->lv_buf_len == XFS_LOG_VEC_ORDERED) {
> > +			if (!lv) {
> > +				lv = shadow;
> > +				lv->lv_item = lip;
> > +			}
> > +			ASSERT(shadow->lv_size == lv->lv_size);
> 
> 			This assert is kind of confusing me. if we have an
> 			ORDERED vector here, couldn't we still have a shadow
> 			size smaller than the current vector?

The size of ordered items never changes, it's always the same constant
overhead.





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux