On Tue, Jul 15, 2025 at 07:49:44AM -0700, Darrick J. Wong wrote:
> > + if (blocks && xfs_dec_fdblocks(tp->t_mountp, blocks, rsvd))
> > + return -ENOSPC;
> > + if (rtextents && xfs_dec_frextents(tp->t_mountp, rtextents) < 0) {
>
> xfs_dec_frextents is checked for a negative return value, then why isn't
> xfs_dec_fdblocks given the same treatment? Or, since IIRC both return 0
> or -ENOSPC you could omit the "< 0" ?
No good reason, I'll make sure they use the same scheme. I don't care
which one, so if you prefer the shorter one I'll go for that.
