On Tue, Jul 15, 2025 at 02:25:41PM +0200, Christoph Hellwig wrote:
> Almost no users of the typedef left, kill it and switch the remaining
> users to use the underlying struct.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks good,
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>
--D
> ---
> fs/xfs/xfs_log.c | 6 +++---
> fs/xfs/xfs_log_priv.h | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 793468b4d30d..bc3297da2143 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -3092,16 +3092,16 @@ xfs_log_force_seq(
> */
> void
> xfs_log_ticket_put(
> - xlog_ticket_t *ticket)
> + struct xlog_ticket *ticket)
> {
> ASSERT(atomic_read(&ticket->t_ref) > 0);
> if (atomic_dec_and_test(&ticket->t_ref))
> kmem_cache_free(xfs_log_ticket_cache, ticket);
> }
>
> -xlog_ticket_t *
> +struct xlog_ticket *
> xfs_log_ticket_get(
> - xlog_ticket_t *ticket)
> + struct xlog_ticket *ticket)
> {
> ASSERT(atomic_read(&ticket->t_ref) > 0);
> atomic_inc(&ticket->t_ref);
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index 39a102cc1b43..a9a7a271c15b 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -144,7 +144,7 @@ enum xlog_iclog_state {
>
> #define XLOG_COVER_OPS 5
>
> -typedef struct xlog_ticket {
> +struct xlog_ticket {
> struct list_head t_queue; /* reserve/write queue */
> struct task_struct *t_task; /* task that owns this ticket */
> xlog_tid_t t_tid; /* transaction identifier */
> @@ -155,7 +155,7 @@ typedef struct xlog_ticket {
> char t_cnt; /* current unit count */
> uint8_t t_flags; /* properties of reservation */
> int t_iclog_hdrs; /* iclog hdrs in t_curr_res */
> -} xlog_ticket_t;
> +};
>
> /*
> * - A log record header is 512 bytes. There is plenty of room to grow the
> --
> 2.47.2
>
>
