On Thu, Jun 19, 2025 at 12:42:39PM +1000, Dave Chinner wrote: > > > The external log device can have a different sector size to > > > the rest of the filesystem. This series looks like it removes the > > > ability to validate that the log device sector size in teh > > > superblock is valid for the backing device.... > > > > I don't follow. Do you mean it remove the future possibility to do this? > > No, I mean that this: > > # mkfs.xfs -l sectsize=512,logdev=/dev/nvme1n1 -d sectsize=4k .... /dev/nvme0n1 > > is an valid filesystem configuration and has been for a long, long > time. i.e. the logdev does not have to have the same physical sector > size support as the data device. Sure, and I've never disagreed. But you'd not explained how that is relevant for this patch. The bt_meta_sectorsize is only used for asserting the alignment of cached buffers, and we place no buffers (cached or uncached) on the log device ever.
