On Wed, Jun 18, 2025 at 09:51:10AM +1000, Dave Chinner wrote: > On Tue, Jun 17, 2025 at 12:52:05PM +0200, Christoph Hellwig wrote: > > The file system only has a single file system sector size. > > The external log device can have a different sector size to > the rest of the filesystem. This series looks like it removes the > ability to validate that the log device sector size in teh > superblock is valid for the backing device.... I don't follow. Do you mean it remove the future possibility to do this? Even then it would be better to do this directly based off the superblock and not use a field in the buftarg currently only used for cached buffers (which aren't used on anything but the main device).