On Tue, Jun 17, 2025 at 01:21:38PM +0100, John Garry wrote: > On 17/06/2025 13:15, John Garry wrote: >> On 17/06/2025 11:52, Christoph Hellwig wrote: >>> xfs_configure_buftarg( >>> - struct xfs_buftarg *btp, >>> - unsigned int sectorsize) >>> + struct xfs_buftarg *btp) >>> { >> >> This is now just really a wrapper for calling >> xfs_configure_buftarg_atomic_write() - is that ok? > > And the bdev_can_atomic_write() call [not shown] is superfluous already, as > we have that same check in bdev_atomic_write_unit_{min,max}_bytes() I'll look into it, that should simplify things further.