Re: [PATCH 10/11] iomap: replace iomap_folio_ops with iomap_write_ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 17, 2025 at 03:25:43PM -0700, Joanne Koong wrote:
> >  vm_fault_t iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops,
> >                 void *private);
> 
> Maybe you'll hate this idea but what about just embedding struct
> iomap_ops inside iomap_write_ops?
> 
> eg
>  struct iomap_write_ops {
>         struct iomap_ops iomap_ops;
>         struct folio *(*get_folio)(struct iomap_iter *iter, loff_t pos,
>                         unsigned len);
>        ...
> }
> 
> and then only having to pass in iomap_write_ops?

That would only help use with the first layer of calls, as that already
"consumes" the iomap_ops.  So I'm not sure if that's really all that
useful.




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux