On Tue, Jun 17, 2025 at 03:25:43PM -0700, Joanne Koong wrote: > > vm_fault_t iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops, > > void *private); > > Maybe you'll hate this idea but what about just embedding struct > iomap_ops inside iomap_write_ops? > > eg > struct iomap_write_ops { > struct iomap_ops iomap_ops; > struct folio *(*get_folio)(struct iomap_iter *iter, loff_t pos, > unsigned len); > ... > } > > and then only having to pass in iomap_write_ops? That would only help use with the first layer of calls, as that already "consumes" the iomap_ops. So I'm not sure if that's really all that useful.