Search Linux Wireless

Re: [PATCH wireless v2] wifi: mac80211: fix reporting of all valid links in sta_set_sinfo()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2025-09-04 at 16:10 +0530, Sarika Sharma wrote:
> 
> +		/* currently assigning all valid links to sinfo in order
> +		 * to iterate over all possible links
> +		 */
> +		sinfo->valid_links = sta->sta.valid_links;
>  		ether_addr_copy(sinfo->mld_addr, sta->addr);
>  		for_each_valid_link(sinfo, link_id) {

To me, "currently" implies this code might change later (as in "the way
the code is currently"), not "at this place in the code"? Maybe that's
just my understanding of English, but anyway I've changed it to

                ether_addr_copy(sinfo->mld_addr, sta->addr);
+
+               /* assign valid links first for iteration */
+               sinfo->valid_links = sta->sta.valid_links;
+
                for_each_valid_link(sinfo, link_id) {


which seemed clearer.

johannes





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux