On 9/10/2025 2:15 PM, Johannes Berg wrote:
On Wed, 2025-09-10 at 10:42 +0200, Johannes Berg wrote:
On Thu, 2025-09-04 at 16:10 +0530, Sarika Sharma wrote:
+ /* currently assigning all valid links to sinfo in order
+ * to iterate over all possible links
+ */
+ sinfo->valid_links = sta->sta.valid_links;
ether_addr_copy(sinfo->mld_addr, sta->addr);
for_each_valid_link(sinfo, link_id) {
To me, "currently" implies this code might change later (as in "the way
the code is currently"), not "at this place in the code"? Maybe that's
just my understanding of English, but anyway I've changed it to
ether_addr_copy(sinfo->mld_addr, sta->addr);
+
+ /* assign valid links first for iteration */
+ sinfo->valid_links = sta->sta.valid_links;
+
for_each_valid_link(sinfo, link_id) {
which seemed clearer.
Actually, wait - I'll still want to reword this, but given the whole
netlink size issues etc. we don't really need this patch on wireless
anyway.
Okay, sure.
johannes
