Andrey Skvortsov <andrej.skvortzov@xxxxxxxxx> wrote: > This is needed for AP mode. Otherwise client sees the network, but > can't connect to it. > > REG_FWHW_TXQ_CTRL+1 is set to WLAN_TXQ_RPT_EN (0x1F) in common mac > init function (__rtw8723x_mac_init), but the value was overwritten > from mac table later. mac_postinit is run after registers from mac > table are set, this allows to set correct values. > > Tested on rtl8723cs, that reuses rtw8703b driver. > > Signed-off-by: Andrey Skvortsov <andrej.skvortzov@xxxxxxxxx> > --- > drivers/net/wireless/realtek/rtw88/rtw8703b.c | 1 + > drivers/net/wireless/realtek/rtw88/rtw8723d.c | 1 + > drivers/net/wireless/realtek/rtw88/rtw8723x.c | 9 ++++++++- > drivers/net/wireless/realtek/rtw88/rtw8723x.h | 6 ++++++ > 4 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtw88/rtw8703b.c > b/drivers/net/wireless/realtek/rtw88/rtw8703b.c > index 03475af973b52..821c28d9cb5d4 100644 > --- a/drivers/net/wireless/realtek/rtw88/rtw8703b.c > +++ b/drivers/net/wireless/realtek/rtw88/rtw8703b.c > @@ -1832,6 +1832,7 @@ static const struct rtw_chip_ops rtw8703b_ops = { > .power_on = rtw_power_on, > .power_off = rtw_power_off, > .mac_init = rtw8723x_mac_init, > + .mac_postinit = rtw8723x_mac_postinit, If chips don't have this ops, please give them NULL to be clear that we don't miss it. Since these two patches are small, I don't mind to combine them together. Make decision yourself. By the way, please select rtw-next tree by [PATCH v3 rtw-next]. > .dump_fw_crash = NULL, > .shutdown = NULL, > .read_efuse = rtw8703b_read_efuse, [...]