On 25-06-30 01:51, Ping-Ke Shih wrote: > Andrey Skvortsov <andrej.skvortzov@xxxxxxxxx> wrote: > > This is needed for AP mode. Otherwise client sees the network, but > > can't connect to it. > > > > REG_FWHW_TXQ_CTRL+1 is set to WLAN_TXQ_RPT_EN (0x1F) in common mac > > init function (__rtw8723x_mac_init), but the value was overwritten > > from mac table later. > > Since the tables were copied from vendor driver, I suspect people might > overwrite the tables again resulting in regression. > > So we can add a mac_post_init to set the value after loading parameters: > > rtw_mac_init(rtwdev); // not set REG_FWHW_TXQ_CTRL+1 to WLAN_TXQ_RPT_EN > > chip->ops->phy_set_param(rtwdev); // "0x421, 0x0000000F," by table > > rtw_mac_postinit(rtwdev); // set REG_FWHW_TXQ_CTRL+1 to WLAN_TXQ_RPT_EN > > Only rtw8703b/rtw8723d implement postinit ops. > Thanks for the feedback, I'll add this in v2. -- Best regards, Andrey Skvortsov
