Search Linux Wireless

Re: [PATCH] wifi: mac80211: make VHT opmode NSS ignore a debug message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Johannes,


Thank you for your patch, and sorry for not replying in the other thread.

Am 08.07.25 um 12:58 schrieb Johannes Berg:
From: Johannes Berg <johannes.berg@xxxxxxxxx>

There's no need to always print it, it's only useful for
debugging specific client issues. Make it a debug message.

Excuse my ignorance, but I wonder if it’s a firmware bug (of the access point), if this situation occurs?

Also, I do have a problem with that Telekom Speedport 3, that sometimes – despite still connected Wi-Fi – no network connection is possible, and re-connecting fixes it. It happens much later to the message, so I assume it’s unrelated, but no warnings would give me more confidence into the Telekom router.

Reported-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
Link: https://lore.kernel.org/linux-wireless/20250529070922.3467-1-pmenzel@xxxxxxxxxxxxx/
Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
---
  net/mac80211/vht.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/mac80211/vht.c b/net/mac80211/vht.c
index c5c5d16ed6c8..b099d79e8fbb 100644
--- a/net/mac80211/vht.c
+++ b/net/mac80211/vht.c
@@ -672,8 +672,9 @@ u32 __ieee80211_vht_handle_opmode(struct ieee80211_sub_if_data *sdata,
  				sta_opmode.changed |= STA_OPMODE_N_SS_CHANGED;
  			}
  		} else {
-			pr_warn_ratelimited("Ignoring NSS change in VHT Operating Mode Notification from %pM with invalid nss %d",
-					    link_sta->pub->addr, nss);
+			sdata_dbg(sdata,
+				  "Ignore NSS change to invalid %d in VHT opmode notif from %pM",
+				  nss, link_sta->pub->addr);

As with my original patch, would printing the current “NSS value” be useful? At least for me, who does not know how to get that value from a running system.

  		}
  	}


Kind regards,

Paul




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux