On Thu, 2025-06-26 at 21:37 +0530, Maharaja Kennadyrajan wrote: > > > +static bool > +ieee80211_is_csa_in_progress(struct ieee80211_sub_if_data *sdata) > +{ > + /* > + * In MLO, check the CSA flags 'active' and 'waiting_bcn' for all > + * the links. > + */ > + unsigned int link_id; > + > + guard(rcu)(); > + > + for (link_id = 0; link_id < ARRAY_SIZE(sdata->link); > + link_id++) { > + struct ieee80211_link_data *link = > + rcu_dereference(sdata->link[link_id]); > + > + if (!link) > + continue; We should probably add for_each_link_data_rcu() instead of open-coding it here, even if we'd only have a single user for it now. > + if (!(link->conf > I pointed out elsewhere (possibly multiple times?), that this check is useless. johannes