Thank you for reviewing!
On 7/1/25 7:49 PM, Jeff Johnson wrote:
> On 6/30/2025 12:43 AM, Muhammad Usama Anjum wrote:
>
> Subject has incorrect prefix, should be "wifi: ath11k: "
>
> And ideally it should mention HAL SRNG since it is specific to that allocation
I'll fix the subject.
>
>> Don't deinitialize and reinitialize the HAL helpers. The dma memory is
>> deallocated and there is high possibility that we'll not be able to get
>> the same memory allocated from dma when there is high memory pressure.
>>
>> Tested-on: WCN6855 WLAN.HSP.1.1-03926.13-QCAHSPSWPL_V2_SILICONZ_CE-2.52297.6
>
> not quite the right format since it is missing hw version and bus
I've been using the same tag from last accepted patches. How to construct the
correct patch?
>
>>
>> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
>> ---
>> drivers/net/wireless/ath/ath11k/core.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
>> index 4488e4cdc5e9e..bc4930fe6a367 100644
>> --- a/drivers/net/wireless/ath/ath11k/core.c
>> +++ b/drivers/net/wireless/ath/ath11k/core.c
>> @@ -2213,14 +2213,9 @@ static int ath11k_core_reconfigure_on_crash(struct ath11k_base *ab)
>> mutex_unlock(&ab->core_lock);
>>
>> ath11k_dp_free(ab);
>> - ath11k_hal_srng_deinit(ab);
>>
>> ab->free_vdev_map = (1LL << (ab->num_radios * TARGET_NUM_VDEVS(ab))) - 1;
>>
>> - ret = ath11k_hal_srng_init(ab);
>> - if (ret)
>> - return ret;
>> -
>> clear_bit(ATH11K_FLAG_CRASH_FLUSH, &ab->dev_flags);
>>
>> ret = ath11k_core_qmi_firmware_ready(ab);
>
> does this patch have any dependency upon the 1/3 patch?
No
> if not, then it should be sent separately since it should go through the ath
> tree instead of through the mhi tree.
Ohh... I see. I'll send it separately.
>
> /jeff
