On 5/21/2025 10:11 PM, Johannes Berg wrote: > On Wed, 2025-05-21 at 22:00 +0530, Roopni Devanathan wrote: >> >> Using 'int' leads to adding NLA_U32 policy. I think using 'int' is >> costlier than using 's8'. Can we just revert back to using 's8' instead? >> There will still be a default value of -1 and the radio indices will not >> require u32 value anyway. > > I don't follow. You can always take a U8 value and put it into an int?? > > I think that NLA_U8 is a bit useless if you have to range-check anyway, > since an NLA_U8 attribute is actually the same size as an NLA_U32 > attribute, it just has a more restricted range (but you restrict it to > the n_radios anyway!). > > But I don't see how this is related at all. > > I think 'int' is better internally, and NLA_U8 is fine externally. > Okay, got it. The policy can retain NLA_U8, just the radio_id datatype usage internally needs to be changed to int. Thanks for clarifying. > johannes
