Search Linux Wireless

Re: [PATCH wireless-next v9 3/3] wifi: mac80211: Set RTS threshold on per-radio basis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2025-04-29 at 09:30 +0530, Roopni Devanathan wrote:

> +++ b/include/net/mac80211.h
> @@ -4569,7 +4569,8 @@ struct ieee80211_ops {
>  			    struct ieee80211_key_conf *key,
>  			    struct ieee80211_key_seq *seq);
>  	int (*set_frag_threshold)(struct ieee80211_hw *hw, u32 value);
> -	int (*set_rts_threshold)(struct ieee80211_hw *hw, u32 value);
> +	int (*set_rts_threshold)(struct ieee80211_hw *hw, u8 radio_id,
> +				 u32 value);

That should probably have documentation updates. And passing a negative
value to a u8 seems awkward? Maybe that should just be 'int'? For a
value that's likely passed in a register, u8 will probably require more
(machine) code anyway.

johannes





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux