On 5/21/2025 3:28 PM, Johannes Berg wrote: > On Wed, 2025-05-21 at 15:27 +0530, Roopni Devanathan wrote: >>> >> Okay, understood. If I can directly assign -1 as default value to radio_id, >> then I can cut down this definition entirely. I can re-write radio_id >> declaration in nl80211_set_wiphy() as: >> s8 radio_id = -1; >> instead of >> u8 radio_id = NL80211_WIPHY_RADIO_ID_DEFAULT; >> >> This will solve the whole problem. Is that alright? > > Seems fine, there's probably only one place anyway that does this. > > If there are multiple I guess you can have a function a la > nl80211_link_id_or_invalid(). > Sure, but there's only one place this is needed. So I'll go with directly assigning -1 as default value to radio_id. Thank you for a detailed review! > johannes
