Shayne Chen <shayne.chen@xxxxxxxxxxxx> wrote: [...] > + > +bool mt7996_eeprom_has_background_radar(struct mt7996_dev *dev) > +{ > + switch (mt76_chip(&dev->mt76)) { > + case MT7996_DEVICE_ID: > + if (dev->var.type == MT7996_VAR_TYPE_233) > + return false; > + break; > + case MT7992_DEVICE_ID: > + if (dev->var.type == MT7992_VAR_TYPE_23) > + return false; > + break; > + case MT7990_DEVICE_ID: { > + u8 path, rx_path, nss, *eeprom = dev->mt76.eeprom.data; > + > + mt7996_eeprom_parse_stream(eeprom, MT_BAND1, &path, &rx_path, &nss); > + /* Disable background radar capability in 3T3R */ > + if (path == 3 || rx_path == 3) > + return false; > + break; > + } The indentation of close brace looks weird. Since -Wdeclaration-after-statement is dropped, I think compilers will not warn without the braces. But note that it is still not recommended to put declarations in the middle. > + default: > + return false; > + } > + > + return true; > +}