Shayne Chen <shayne.chen@xxxxxxxxxxxx> wrote: [...] > - if (is_mt7996(&dev->mt76)) { > + switch (mt76_chip(&dev->mt76)) { > + case MT7992_DEVICE_ID: > + RXQ_CONFIG(MT_RXQ_BAND1_WA, WFDMA0, MT_INT_RX_DONE_WA_EXT, MT7996_RXQ_MCU_WA_EXT); > + RXQ_CONFIG(MT_RXQ_BAND1, WFDMA0, MT_INT_RX_DONE_BAND1, MT7996_RXQ_BAND1); > + break; > + case MT7990_DEVICE_ID: Does it mean MT7990_DEVICE_ID_2/MT7992_DEVICE_ID_2 (suffix with _2) has different behavior from MT7990_DEVICE_ID/MT7992_DEVICE_ID ? > + RXQ_CONFIG(MT_RXQ_BAND1, WFDMA0, MT_INT_RX_DONE_BAND1, MT7996_RXQ_BAND1); > + RXQ_CONFIG(MT_RXQ_TXFREE_BAND0, WFDMA0, > + MT_INT_RX_TXFREE_BAND0_MT7990, MT7990_RXQ_TXFREE0); > + if (dev->hif2) > + RXQ_CONFIG(MT_RXQ_TXFREE_BAND1, WFDMA0, > + MT_INT_RX_TXFREE_BAND1_MT7990, MT7990_RXQ_TXFREE1); > + break; > + case MT7996_DEVICE_ID: > + default: > /* mt7996 band2 */ > - RXQ_CONFIG(MT_RXQ_BAND2, WFDMA0, MT_INT_RX_DONE_BAND2, MT7996_RXQ_BAND2); > RXQ_CONFIG(MT_RXQ_BAND2_WA, WFDMA0, MT_INT_RX_DONE_WA_TRI, MT7996_RXQ_MCU_WA_TRI); > - } else { > - /* mt7992 band1 */ > - RXQ_CONFIG(MT_RXQ_BAND1, WFDMA0, MT_INT_RX_DONE_BAND1, MT7996_RXQ_BAND1); > - RXQ_CONFIG(MT_RXQ_BAND1_WA, WFDMA0, MT_INT_RX_DONE_WA_EXT, MT7996_RXQ_MCU_WA_EXT); > + RXQ_CONFIG(MT_RXQ_BAND2, WFDMA0, MT_INT_RX_DONE_BAND2, MT7996_RXQ_BAND2); > + break; > } > > if (dev->has_rro) {