Re: [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx

Re: [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx_work

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: Abdun Nihaal <abdun.nihaal@xxxxxxxxx>, linux-wireless@xxxxxxxxxxxxxxx, Kalle Valo <kvalo@xxxxxxxxxx>

Subject: Re: [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx_work

From: Markus Elfring <Markus.Elfring@xxxxxx>

Date: Sun, 30 Mar 2025 14:14:54 +0200

Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, "John W. Linville" <linville@xxxxxxxxxxxxx>

In-reply-to: <20250330104532.44935-1-abdun.nihaal@gmail.com>

References: <20250330104532.44935-1-abdun.nihaal@gmail.com>

Ui-outboundreport: notjunk:1;M01:P0:g1kxIRJVlcE=;WtGBbSlpjLeVlxgsovze4yhUkWe OwBBxgGP0Pq+V2zkJAcLHOvaBCTNwCljlRWc8WAqMFDTr3gE86gOEA71C/eLbr8nCadw+0KCh VeyZbk7MgkjGTyF/eh6g/UBEodxdD0+Ny2SZgFTgClINqyRHFxHfB2/OYVZ8E5VohAnDI8TQy 3gdvgvUq/THWDpjvuyZUJ0g5aElqdhX5wVTYVA28RWiUMgA3I2CPbP7ePSMCtERWRD1Bxi+As jvlS5mAOV9BIbpeiChANlE/LhdwCS2Iswg5zYKhHbFfnFJ0wpKWvTLT9y8MDx6atIX022N0K8 qQALX9BK6q0/gS90L3up6cKFwAHw7FXHTVH+CzZik06hS0yPeSUBDNtVFrrU/tVJBzD5aFUof RbAVkjWNLbY2gR0916fHiLBddbnWgAtt2prNwQtnmMnjWWt9CB6V9XOk9RN5rj+SDX4ct9Xh2 VOaTfc2FCaFbwhSRCPGDmo1m/OSmthhI9cMCUPkdKMgyrramRv22X2wuu3UiKvu9PPR+vqnxV D9NIwYtnkztqwxcHmqs0cnPFxtlfBMAFDtnEKk874xBOqM5hBFlTOQ0RfSbXVdH0x9mB6iUwu MtYseYXSP+B4FTe6qkLKDz9J87mvj4rchfOktgYPbwBqrpE/EhdyL3aPbtXAZHkQ0zF+zsKAP ii0pn5s/lH63VjcOzUqBJEdgKKNis00v0g9bOjOSyug9MiYOj9xSUqdetcQHzKLUm1RUjdfJT 1yzvGvPWkAljsW7MGhugJHKnAtKLT0v21MVAeo20ZRbSSFcqy7HmU7mo/WrqG69pkg6wxZFEr KLnt9TmXKg+5IJ8BtjzK6DjtIDxkOy7rmsiAfUkWp+iFT8btX8BnQL1k50yvpHfMywqOc3U5B Cw+iWUIRKGXwZajmEGvMg8UeYhHZnXjHw74l9ymsx4KSzBbhYBjZRg/e9t/xGwJyfPP95fl34 i5LY1Qchx5C6lkFSmWE1Meabiav9Y3tObXuiHTESSt04JzOSrnwOFansZXkDxFkAmClOpkQ4m vem6+RiL336XvmPhcE9N9Sxt0Bv9Nu2XUTb9rWiU3smq56Xe7qKrIuwaHIGGNUEShkL4cL5Pr 5kyEt1zoapZm85v5Q+nWf3mYDh4gE7x3OV/CRgc++AsISrjrJDABuZMtkvD50HRxMk2PkBcq3 mh555dyUjTIiLWUtwynojZ/YLylfo+NJI3TqwO946H7MmEfUiB83h7GodkvsqUcaIfwQD7h+l O1/dyMk+XP/PkTDOaW71rzKcQYgmdnrIvJw2a2oMfzTp3nUSM3IN+v9U3e1NNiLDuZbNe16f3 f+ExbMYdsSZrSBF0TwWI5W366BOFJnxQA4iukuX/z+rvrOcPM0P8exOMMHe/xWUxiLkhEJsd8 M7a57jHZLMmBTl6aJnZroz0WPCTflTKME3C75AEcdtrvJ2k5hfRO0MDfH7Ub6pjqSxfffPhwV euNEiryNaDQ6BsAmpnjaaTEfU34juQiaMF29UOO9pK9KHMvnT8t7sE9T71ZvPwUdCqcNAsg==

User-agent: Mozilla Thunderbird

> The skb dequeued from tx_queue is lost when wl1251_ps_elp_wakeup fails
> with a -ETIMEDOUT error. Fix that by queueing the skb back to tx_queue.

Would you like to append parentheses to any function names?

Regards,
Markus