Re: [PATCH v2] wifi: brcmfmac: fix memory leak in brcmf_get_module

Re: [PATCH v2] wifi: brcmfmac: fix memory leak in brcmf_get_module_param

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: Abdun Nihaal <abdun.nihaal@xxxxxxxxx>, brcm80211-dev-list.pdl@xxxxxxxxxxxx, brcm80211@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>

Subject: Re: [PATCH v2] wifi: brcmfmac: fix memory leak in brcmf_get_module_param

From: Markus Elfring <Markus.Elfring@xxxxxx>

Date: Sun, 30 Mar 2025 14:10:15 +0200

Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Jacobe Zang <jacobe.zang@xxxxxxxxxx>, Jeff Johnson <jeff.johnson@xxxxxxxxxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxx>, Ondřej Jirman <megi@xxxxxx>, Sai Krishna <saikrishnag@xxxxxxxxxxx>, Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>, Toke Høiland-Jørgensen <toke@xxxxxxx>, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>

In-reply-to: <20250330103425.44197-1-abdun.nihaal@gmail.com>

References: <20250330103425.44197-1-abdun.nihaal@gmail.com>

Ui-outboundreport: notjunk:1;M01:P0:jKyH6NX2U7U=;XsArFErJzd0Kl51Sf6JWKx4u3rz uBcinJ85KfmypRpjqGqnQ6VQME1V9LluPkxhIm71dzoG9TDTzmJexlpc36Ku0S+Tl2Sj9vD4l p5Vyk86swNcF0WzZ/RZpGb/fc3k1ORN3Bb25Kb6cOzOI4arXF/vx3a5ryIlNGLebJOp85yWBO 287Q8HKqfWFJWDIuGq5JeU7ygCkZwdlaWSkUMKrn0Tj8n0CFBvRN3TA1al3fdMSip8HjYCxWP QHwi0bfQj175sCVmtCNNRnozGjXNMuz+5iL2ak+pnaa7IA2OOv6UK5w3HKLFmD7JorJTElknN Oz6CNfUbwHw9TFw3TTdpf4hx1uOJYVsilB5ltYba5btT15IzWDRaXf8lc1WnDrsM4VP0krlOt YvyiRCW0L/FlKtdhs9EFxoN8HC9ukg0l0LpCF3VhjjFSwXU4hWk62I7xXWY5ll26lW91kbuVY uk5PSlf9TZQLjPnbc9OEiANdhaTRekQ4Oo0Ob+B4Gccxr9uo/o08oOzgts/Fb7z0MbcQBqEkj 7zBtBxfnk3psJqzOldev9OBztnEbtYUcvBZCzNmb2n+ed/WrObMb+rviVahhIcNT1eDOOjxhu fZbX+tJRplSlHp761wrlNVqXltH8VKb0B8/8C6U2KptBJahvDs3qd1dGjS/COf1kRL/u+0AW2 kSBqUyibC469JYXaylUrq99ibwleLYd9kRIv3XBwmuWxqyhzpDf4yaiUV5Z4TKPt2GiOUBgrD Ff2J2XTAo5wzVYATNVyFWKkX3UDrUcjy4/Mms3qbiRPaSxyB79poAQvWzWpqF6WxFC1gt5vt3 Q/2hcn97RsmOhLARicHLa8g0bLERzwNxOzHKQ1f2bz037Dl5JrsA3ulgEw+yKJ7k02nzCrOBr dncIwb7Xhh7EtolSv0l2TcknXWt1i+lieVEy2bUEdtKOqv+4HLN7B/ORPmX37pFA/9SYdCopd cTRwWFZmdctvSmm2frfE5RP9VvMohrBfMOakbrvHVXnlGftqtPsRxjBuKC4BKnCu6anXZnVxS aPIeN72C+HH93Z9rXsqT6NQDggW+9HlzAT1SfjxLMru/ISGp2zFVorv08GXWuRFSzANV9WzT7 6AXiWX0M0g6P3p8dQbi4IcOxYMdj5zgfFz5O6h4K62lLwVBo+j+DP8cjIJ4MUTCpn9clzKZmE vEktLQx3LtC0jBfDfNA220xHaWx1kzs51h0gGZ/K8eoxFGYfUut9sAiqUoARV4g77/EaMTooF NcBDk9bcBcnXLh2zAWFpgX0BzyMCw6YfYWP2G2mBKDJ4zG8RM3WecSwj9p2BY5Ghg6hMqdMzD v9HwXUETpuZ9D8UuWt7jBEkzz2LXT8YK8jaeip4O7K/ZNNQZWkYPUCoId/LceGRNK+zxjoENM /39alYEvT11fNTGnivcyok6MVbD0ctgJSfe3Y05gtK46Y4oZZdcPJZr3jrS2svq2bmiMEt3EY fiwlrZbzTgz2E6UdvWqcR7+tJJwrQQVYwGDAzCy4nt2VrRSCL

User-agent: Mozilla Thunderbird

> The memory allocated for settings is not freed when brcmf_of_probe
> fails. Fix that by freeing settings before returning in error path.

  failed?

Would you like to append parentheses to any function names?

Regards,
Markus