Hi Tudor,
On Fri, Aug 22, 2025 at 09:14:03AM +0100, Tudor Ambarus wrote:
> On 8/21/25 7:34 PM, Brian Masney wrote:
> > On Tue, Aug 19, 2025 at 11:45:38AM +0000, Tudor Ambarus wrote:
> >> +static long acpm_clk_round_rate(struct clk_hw *hw, unsigned long rate,
> >> + unsigned long *parent_rate)
> >> +{
> >> + /*
> >> + * We can't figure out what rate it will be, so just return the
> >> + * rate back to the caller. acpm_clk_recalc_rate() will be called
> >> + * after the rate is set and we'll know what rate the clock is
> >> + * running at then.
> >> + */
> >> + return rate;
> >> +}
> >
> > ...
> >
> >> +
> >> +static const struct clk_ops acpm_clk_ops = {
> >> + .recalc_rate = acpm_clk_recalc_rate,
> >> + .round_rate = acpm_clk_round_rate,
> >> + .set_rate = acpm_clk_set_rate,
> >> +};
> >
> > The round_rate clk op is deprecated. Please convert this over to use
> > determine_rate.
>
> I can do that, sure. Shall I also update the kdoc for round_rate(), mark it
> as deprecated and add your Suggested-by tag? It would help other newcomers.
I am working to remove round_rate from the clk core and the various
drivers. Your driver just needs to be updated similar to this:
https://lore.kernel.org/all/20250710-clk-imx-round-rate-v1-10-5726f98e6d8d@xxxxxxxxxx/
Brian
