On 8/21/25 7:34 PM, Brian Masney wrote: > Hi Tudor, Hi, Brian, > > On Tue, Aug 19, 2025 at 11:45:38AM +0000, Tudor Ambarus wrote: >> +static long acpm_clk_round_rate(struct clk_hw *hw, unsigned long rate, >> + unsigned long *parent_rate) >> +{ >> + /* >> + * We can't figure out what rate it will be, so just return the >> + * rate back to the caller. acpm_clk_recalc_rate() will be called >> + * after the rate is set and we'll know what rate the clock is >> + * running at then. >> + */ >> + return rate; >> +} > > ... > >> + >> +static const struct clk_ops acpm_clk_ops = { >> + .recalc_rate = acpm_clk_recalc_rate, >> + .round_rate = acpm_clk_round_rate, >> + .set_rate = acpm_clk_set_rate, >> +}; > > The round_rate clk op is deprecated. Please convert this over to use > determine_rate. I can do that, sure. Shall I also update the kdoc for round_rate(), mark it as deprecated and add your Suggested-by tag? It would help other newcomers. Thanks, ta