On 31/07/2025 10:33, Zhen Ni wrote:
> The current error handling in exynos_srom_probe() has a resource leak
> in the of_platform_populate() failure path. When this function fails
> after successful resource allocation, srom->reg_base is not released.
>
> To fix this issue, replace of_iomap() with
> devm_platform_ioremap_resource(). devm_platform_ioremap_resource()
> is a specialized function for platform devices.
Don't explain us kernel code. Drop sentence.
> It allows 'srom->reg_base' to be automatically released whether the
> probe function succeeds or fails.
It's obvious.
>
> Besides, use IS_ERR() instead of !srom->reg_base
I don't understand this. You keep explaining the code and this suggests
you made change here not related to original case. Can you return
srom->reg_base here? No?
> as the return value of devm_platform_ioremap_resource()
> can either be a pointer to the remapped memory or
> an ERR_PTR() encoded error code if the operation fails.
>
Missing fixes and cc-stable.
> Signed-off-by: Zhen Ni <zhen.ni@xxxxxxxxxxxx>
> ---
> drivers/memory/samsung/exynos-srom.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/exynos-srom.c
> index e73dd330af47..d913fb901973 100644
> --- a/drivers/memory/samsung/exynos-srom.c
> +++ b/drivers/memory/samsung/exynos-srom.c
> @@ -121,20 +121,18 @@ static int exynos_srom_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> srom->dev = dev;
> - srom->reg_base = of_iomap(np, 0);
> - if (!srom->reg_base) {
> + srom->reg_base = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(srom->reg_base)) {
> dev_err(&pdev->dev, "iomap of exynos srom controller failed\n");
> - return -ENOMEM;
> + return PTR_ERR(srom->reg_base);
How did you test it?
Best regards,
Krzysztof
