Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: 17 July 2025 04:59 PM > To: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx>; 'Krzysztof Kozlowski' > <krzysztof.kozlowski@xxxxxxxxxx> > Cc: vkoul@xxxxxxxxxx; kishon@xxxxxxxxxx; robh@xxxxxxxxxx; > krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; > andre.draszik@xxxxxxxxxx; peter.griffin@xxxxxxxxxx; neil.armstrong@xxxxxxxxxx; > kauschluss@xxxxxxxxxxx; ivo.ivanov.ivanov1@xxxxxxxxx; > m.szyprowski@xxxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; linux- > phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung- > soc@xxxxxxxxxxxxxxx; rosa.pila@xxxxxxxxxxx; dev.tailor@xxxxxxxxxxx; > faraz.ata@xxxxxxxxxxx; muhammed.ali@xxxxxxxxxxx; > selvarasu.g@xxxxxxxxxxx > Subject: Re: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 HS phy compatible > > On 17/07/2025 13:13, Pritam Manohar Sutar wrote: > >> > >> > >> Nothing is explained in changelog/cover letter. You claim you only added Rb > tag. > >> This is an entirely silent change while keeping the review. > > > > Will add more explanations in cover letter/changelog why this block is added. > > > >> Combined with not even following DTS style! > > > > Ok got it. Will change supplies name as below avdd075_usb => > > avdd075-usb > > avdd18_usb20 => avdd18-usb20 > > avdd33_usb20 => avdd33-usb20 > > > > Confirm the above change that is meant in terms of DTS style. > Yes. I have doubts that actual supplies have suffix usb20. Are there more than > one avdd18 for this block? > Yes, there are more than one vdd18 supplies for this block. Re-analysed your comment on adding new supplies. Going to re-use existing supplies as mentioned below, rather than introducing new supplies dvdd-usb20-supply => for 0.75v vddh-usb20-supply => for 1.8v vdd33-usb20-supply => for 3.3v > Best regards, > Krzysztof Thank you. Regards, Pritam
