On 21/07/2025 04:30, ew kim wrote: > Add the device tree binding documentation for the Samsung Exynos Automotive > ABOX generic audio management core. This binding describes how to configure > the maximum number of PCM playback, PCM capture, and dummy I2S backend > instances for the ABOX core. Actual hardware functionality is provided > by child audio sub-drivers. > > Signed-off-by: ew kim <ew.kim@xxxxxxxxxxx> > --- > .../bindings/sound/samsung,exynosauto.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml > > diff --git a/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml b/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml > new file mode 100644 > index 000000000000..b1e49f38ffe9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/samsung,exynosauto.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung Exynos Automotive Abox Generic > + > +maintainers: > + - Eunwoo Kim <ew.kim@xxxxxxxxxxx> > + > +description: | > + The Samsung Exynos Automotive Abox Generic node represents a > + generic audio management platform device inside Exynos Automotive SoCs. No, we do not add bindings for "generic" stuff. Describe the SoC. > + It does not directly control hardware resources itself, but acts as Does not control hardware? so not suitable for bindings and DTS. > + a common interface to manage child audio sub-drivers for PCM playback, > + PCM capture, and I2S dummy backends. Not relevant. > + > + Typically, this node provides configuration for the maximum number of > + PCM playback and capture devices (ALSA PCM) and the maximum number > + of dummy I2S backend devices. The actual hardware control is handled > + by child drivers attached to this generic core. Not relevant. Describe the hardware. > + > + This node must exist for the platform driver to probe, > + even though it does not map any physical hardware address. Drivers are not relevant, read writing bindings. > + > +properties: > + compatible: > + const: samsung,abox_generic You did not implement previous feedback. This does not follow DTS coding style and writing bindings. I already asked you to read DTS coding style and nothing improved, no issues were resolved. > + > + samsung,num-pcm-playback: > + description: Maximum number of PCM playback instances (ALSA PCM devices). > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + samsung,num-pcm-capture: > + description: Maximum number of PCM capture instances (ALSA PCM devices). > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + samsung,num-i2s-dummy-backend: > + description: Maximum number of dummy I2S backend instances. > + $ref: /schemas/types.yaml#/definitions/uint32 Nothing above describes hardware. Bindings are not for ALSA. > + > + '#address-cells': > + description: Required for child nodes that may declare address space. > + const: 2 > + > + '#size-cells': > + description: Required for child nodes that may declare address space. > + const: 1 > + > +required: > + - compatible > + - samsung,num-pcm-playback > + - samsung,num-pcm-capture > + - samsung,num-i2s-dummy-backend > + > +additionalProperties: false > + > +examples: > + - | > + abox_generic { Did you read DTS coding style? > + compatible = "samsung,abox_generic"; > + samsung,num-pcm-playback = <32>; > + samsung,num-pcm-capture = <32>; > + samsung,num-i2s-dummy-backend = <5>; > + status = "disabled"; No. > + #address-cells = <2>; > + #size-cells = <1>; > + }; Best regards, Krzysztof
