On 23/03/2025 23:39, André Draszik wrote:
> The commit bf231e5febcf ("mfd: sec-core: Add support for the Samsung
> s2dos05") adding s2dos05 support didn't add anything related to IRQ
> support, so I assume this works without IRQs.
>
> Rather than printing a warning message in sec_irq_init() due to the
> missing IRQ number, or returning an error due to a missing irq chip
> regmap, just return early explicitly.
>
> This will become particularly important once errors from sec_irq_init()
> aren't ignored anymore in an upcoming patch and helps the reader of
> this code while reasoning about what the intention might be here.
>
> Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>
> ---
> drivers/mfd/sec-irq.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
I am pretty sure s2dos05 wanted interrupts, but that's on them.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof
