On 23/03/2025 23:39, André Draszik wrote:
> When support for PMICs without compatibles was removed in
> commit f736d2c0caa8 ("mfd: sec: Remove PMICs without compatibles"),
> sec_regmap_config effectively became an orphan, because S5M8763X was
> the only user left of it before removal, using the default: case of the
> switch statement.
>
> Subsequently, the accidental new users have been updated, so
> sec_regmap_config is an orphan again, and can and should be removed
> from the code. Doing so will also ensure future additions to support
> new devices in this driver don't forget to add a regmap config.
>
> Drop this fallback regmap config.
>
> Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>
> ---
Please squash it with previous patch. Logically you want to get rid of
default regmap config - that's the change you are making. Your previous
patch - adding regmap_configs for these variants - makes no sense on its
own, because they were using the same regmap config already - the
default one.
Best regards,
Krzysztof
