Hi Claudiu, On Wed, 14 May 2025 at 11:04, Claudiu <claudiu.beznea@xxxxxxxxx> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > > Add a macro to iterate over the module clocks array. This will be useful > in the upcoming commits that move MSTOP support into the clock > enable/disable APIs. > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> Thanks for your patch! > --- a/drivers/clk/renesas/rzg2l-cpg.c > +++ b/drivers/clk/renesas/rzg2l-cpg.c > @@ -1202,6 +1202,13 @@ struct mstp_clock { > > #define to_mod_clock(_hw) container_of(_hw, struct mstp_clock, hw) > > +#define for_each_mstp_clk(mstp_clk, hw, priv) \ > + for (unsigned int i = 0; (priv) && i < (priv)->num_mod_clks; i++) \ > + if ((priv)->clks[(priv)->num_core_clks + i] == ERR_PTR(-ENOENT)) \ > + continue; \ > + else if (((hw) = __clk_get_hw((priv)->clks[(priv)->num_core_clks + i])) && \ > + ((mstp_clk) = to_mod_clock(hw))) s/mstp_clk/mstp_clock/ everywhere, to match the struct name. Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-clk for v6.17, with the above fixed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds