On Wed, May 07, 2025 at 07:09:47PM +0900, Yoshihiro Shimoda wrote: > Renesas R-Car V4H (r8a779g0) has PCIe controller, and it requires > specific firmware downloading. So, add a document about the firmware > how to get. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Looks good to me. But there is a small nit below. Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > --- > Changes from v3: > https://lore.kernel.org/linux-pci/20241024120525.291885-1-yoshihiro.shimoda.uh@xxxxxxxxxxx/ > - Rebase on v6.15-rc1. > - Revise some descriptions (reviewed from Manivannan Sadhasivam). > - Add the doc file entry into the MAINTAINER. > > Changes from v2: > https://lore.kernel.org/linux-pci/20240703102937.1403905-1-yoshihiro.shimoda.uh@xxxxxxxxxxx/ > - Rebase on v6.12-rc1. > - Move the document file on Documentation/PCI/. > - Add SPDX-License-Identifier. > > Documentation/PCI/rcar-pcie-firmware.rst | 24 ++++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 25 insertions(+) > create mode 100644 Documentation/PCI/rcar-pcie-firmware.rst > > diff --git a/Documentation/PCI/rcar-pcie-firmware.rst b/Documentation/PCI/rcar-pcie-firmware.rst > new file mode 100644 > index 0000000000000..0e285c4a7cd72 > --- /dev/null > +++ b/Documentation/PCI/rcar-pcie-firmware.rst > @@ -0,0 +1,24 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +================================================= > +Firmware of PCIe controller for Renesas R-Car V4H > +================================================= > + > +Renesas R-Car V4H (r8a779g0) has PCIe controller, and it requires specific > +firmware downloading. The firmware file "104_PCIe_fw_addr_data_ver1.05.txt" > +is available in the datasheet as a text file. But, Renesas is not able to > +distribute the firmware freely. So, it is required to convert the text file > +to a binary, and the binary should be placed in /lib/firmware before > +the driver runs by using the following script: nit: the above wording sounds like the script places the firmware under /lib/firmware, but it is not. - Mani -- மணிவண்ணன் சதாசிவம்
