Re: [PATCH] arm64: dts: renesas: sparrow-hawk: Disable dtc spi_bus_bridge check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Morimoto-san,

On Tue, 13 May 2025 at 01:28, Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> > make dtbs:
> >
> >     arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning (spi_bus_bridge): /soc/spi@e6ea0000: incorrect #address-cells for SPI bus
> >       also defined at arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
> >     arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning (spi_bus_bridge): /soc/spi@e6ea0000: incorrect #size-cells for SPI bus
> >       also defined at arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
> >     arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge'
> >
> > The Sparrow Hawk uses the MSIOF module in I2S mode instead of SPI mode,
> > triggering a conflict between the SPI bus bindings and dtc:
> >   - Serial engines that can be SPI controllers must use "spi" as their
> >     node names,
> >   - Dtc assumes nodes named "spi" are always SPI controllers.
> >
> > Fix this by disabling this specific warning for this board.
> >
> > Fixes: ca764d5321a2cee7 ("arm64: dts: renesas: sparrow-hawk: Add MSIOF Sound support")
> > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Closes: https://lore.kernel.org/20250506192033.77338015@xxxxxxxxxxxxxxxx
> > Suggested-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > ---
> (snip)
> > +DTC_FLAGS_r8a779g3-sparrow-hawk += -Wno-spi_bus_bridge
>
> Thank you for the patch.
>
> But I still get the same warning. I'm using latest linux-next/master
> + this patch. And run this. Am I missing something ?
>
>         > make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml

Works for me:

$ git checkout next-20250512
$ rm -f arch/arm64/boot/dts/renesas/r8a779g3-*dtb; ARCH=arm64
CROSS_COMPILE=aarch64-linux-gnu- make -j 12 defconfig dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
[...]
arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning
(spi_bus_bridge): /soc/spi@e6ea0000: incorrect #address-cells for SPI
bus
  also defined at
arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
arch/arm64/boot/dts/renesas/r8a779g0.dtsi:1269.24-1283.5: Warning
(spi_bus_bridge): /soc/spi@e6ea0000: incorrect #size-cells for SPI bus
  also defined at
arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts:471.9-486.3
arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dtb: Warning
(spi_bus_reg): Failed prerequisite 'spi_bus_bridge'
[...]
$ git am 20250512_geert_renesas_arm64_dts_renesas_sparrow_hawk_disable_dtc_spi_bus_bridge_check.mbx
$ rm -f arch/arm64/boot/dts/renesas/r8a779g3-*dtb; ARCH=arm64
CROSS_COMPILE=aarch64-linux-gnu- make -j 12 defconfig dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
[... no warning]

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux