Hi Michael,
On Fri, 9 May 2025 at 14:06, Michael Dege <michael.dege@xxxxxxxxxxx> wrote:
> The original driver used magic-number offsets because the register names
> were unknown. Now most of the register names have been disclosed.
>
> Signed-off-by: Michael Dege <michael.dege@xxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/phy/renesas/renesas-ether-serdes.c
> +++ b/drivers/phy/renesas/renesas-ether-serdes.c
> @@ -23,6 +23,55 @@
> #define RENESAS_ETH_SERDES_LOCAL_OFFSET 0x2600
> #define RENESAS_ETH_SERDES_NUM_RETRY_LINKUP 3
>
> +#define BANK_180 0x0180
> +#define VR_XS_PMA_MP_12G_16G_25G_TX_GENCTRL0 0x00c0
> +#define VR_XS_PMA_MP_12G_16G_25G_TX_GENCTRL1 0x00c4
> +#define VR_XS_PMA_MP_12G_16G_TX_GENCTRL2 0x00c8
> +#define VR_XS_PMA_MP_12G_16G_25G_TX_RATE_CTRL 0x00d0
> +#define VR_XS_PMA_MP_12G_16G_25G_TX_EQ_CTRL0 0x00d8
[...]
I think it would be good to move this patch up in the series.
Especially "[PATCH 4/9] phy: renesas: ethernet serdes: add USXGMII
and 5GBASER modes" would become easier to review.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
