On 09/05/2025 14:04, Michael Dege wrote: > From a2f88121b79cdf756dacc9d58ed1ca23ab1c8744 Mon Sep 17 00:00:00 2001 > From: Michael Dege <michael.dege@xxxxxxxxxxx> > Date: Fri, 9 May 2025 12:40:27 +0200 > Subject: [PATCH 8/9] Doc: devicetree: phy: renesas: add compatible for X5H Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> > > Added the compatible string for new Renesas SOC X5H (r8a78000). > > Signed-off-by: Michael Dege <michael.dege@xxxxxxxxxxx> > --- > .../devicetree/bindings/phy/renesas,renesas-ether-serdes.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/phy/renesas,renesas-ether-serdes.yaml b/Documentation/devicetree/bindings/phy/renesas,renesas-ether-serdes.yaml > index 93ab72874228..58e84f703865 100644 > --- a/Documentation/devicetree/bindings/phy/renesas,renesas-ether-serdes.yaml > +++ b/Documentation/devicetree/bindings/phy/renesas,renesas-ether-serdes.yaml > @@ -12,6 +12,7 @@ maintainers: > properties: > compatible: > const: renesas,r8a779f0-ether-serdes > + const: renesas,r8a78000-ether-serdes Never tested. Sending untested code with test bypass is not really appropriate. > > reg: > maxItems: 1 > -- > 2.34.1 > > ________________________________ > > Renesas Electronics Europe GmbH > Registered Office: Arcadiastrasse 10 > DE-40472 Duesseldorf > Commercial Registry: Duesseldorf, HRB 3708 > Managing Director: Carsten Jauch > VAT-No.: DE 14978647 > Tax-ID-No: 105/5839/1793 > > Legal Disclaimer: This e-mail communication (and any attachment/s) is confidential and contains proprietary information, some or all of which may be legally privileged. It is intended solely for the use of the individual or entity to which it is addressed. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful. For obvious reasons we cannot take proprietary code, sorry. Maybe I am the intended recipient of your message, maybe not. I don't want to have any legal questions regarding upstream, public collaboration, thus probably I should just remove your messages. Please talk with your IT that such disclaimers in open-source are not desired (and maybe even harmful). If you do not understand why, please also see: https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835 If you need to go around company SMTP server, then consider using b4 web-relay: https://b4.docs.kernel.org/en/latest/contributor/send.html Please be informed that by responding to this email you agree that all communications from you and/or your company is made public. In other words, all messages originating from you and/or your company will be made public. Best regards, Krzysztof
