On 08/05/2025 11:05, Biju Das wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> >> Sent: 08 May 2025 09:57 >> Subject: Re: [PATCH] memory: renesas-rpc-if: Add missing static keyword >> >> On 07/05/2025 18:21, Biju Das wrote: >>> Fix the below sparse warnings: >>> symbol 'rpcif_impl' was not declared. Should it be static? >>> symbol 'xspi_impl' was not declared. Should it be static? >> >> >> Did you test now your code with sparse and smatch? Otherwise I will wait for more reports. > > Yes, I tested with the instructions in [1] and the patch fixes the above issues. > I meant other issues. So you did not test with smatch? That's your task and you should not rely on the community to provide such tests/checks instead. Please run standard kernel tools for static analysis, like coccinelle, smatch and sparse, and fix reported warnings. Also please check for warnings when building with W=1 for gcc and clang. Most of these commands (checks or W=1 build) can build specific targets, like some directory, to narrow the scope to only your code. The code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof
