On Thu, Apr 17, 2025 at 01:39:14PM +0200, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> CC leds
>
> On Thu, 17 Apr 2025 at 11:33, Wolfram Sang
> <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> > ---
> >
> > Changes since v2:
> > * using function, color, function-enumerator properties now
> >
> > Honestly, this is better than using node names? With V2, the LEDs were
> > named as in the schematics, now they are called:
> >
> > lrwxrwxrwx 1 root root 0 May 12 12:10 green:programming-0 -> ../../devices/platform/leds/leds/green:programming-0
> > lrwxrwxrwx 1 root root 0 May 12 12:10 green:programming-1 -> ../../devices/platform/leds/leds/green:programming-1
> > lrwxrwxrwx 1 root root 0 May 12 12:10 green:programming-2 -> ../../devices/platform/leds/leds/green:programming-2
> > ...
> >
> > Which gets even more confusing if we might later add LEDs not on this
> > board, but on the expansion board. 'green:programming-8' sits where?
> >
> > I really wonder, but if this is the official way now...
>
> Good point! So I'm inclined to take v2...
>
> Let's raise this with the LED people. I don't want to fight Pavel when
> v2 hits the CiP tree ;-)
So, if there is no other opinion here, can we remove function, color,
function-enumerator and just use the node names which match the
schematics? Basically apply V2?
>
> > --- a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db.dts
> > +++ b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-db.dts
> > @@ -10,6 +10,7 @@
> >
> > #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/input/input.h>
> > +#include <dt-bindings/leds/common.h>
> > #include <dt-bindings/net/pcs-rzn1-miic.h>
> > #include <dt-bindings/pinctrl/rzn1-pinctrl.h>
> >
> > @@ -86,7 +87,74 @@ switch-8 {
> > debounce-interval = <20>;
> > gpios = <&pca9698 15 GPIO_ACTIVE_LOW>;
> > };
> > + };
> > +
> > + leds {
> > + compatible = "gpio-leds";
> >
> > + led-dbg0 {
> > + gpios = <&pca9698 0 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_PROGRAMMING;
> > + function-enumerator = <0>;
> > + default-state = "keep";
> > + };
> > +
> > + led-dbg1 {
> > + gpios = <&pca9698 1 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_PROGRAMMING;
> > + function-enumerator = <1>;
> > + default-state = "keep";
> > + };
> > +
> > + led-dbg2 {
> > + gpios = <&pca9698 2 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_PROGRAMMING;
> > + function-enumerator = <2>;
> > + default-state = "keep";
> > + };
> > +
> > + led-dbg3 {
> > + gpios = <&pca9698 3 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_PROGRAMMING;
> > + function-enumerator = <3>;
> > + default-state = "keep";
> > + };
> > +
> > + led-dbg4 {
> > + gpios = <&pca9698 4 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_PROGRAMMING;
> > + function-enumerator = <4>;
> > + default-state = "keep";
> > + };
> > +
> > + led-dbg5 {
> > + gpios = <&pca9698 5 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_PROGRAMMING;
> > + function-enumerator = <5>;
> > + default-state = "keep";
> > + };
> > +
> > + led-dbg6 {
> > + gpios = <&pca9698 6 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_PROGRAMMING;
> > + function-enumerator = <6>;
> > + default-state = "keep";
> > + };
> > +
> > + led-dbg7 {
> > + gpios = <&pca9698 7 GPIO_ACTIVE_HIGH>;
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_PROGRAMMING;
> > + function-enumerator = <7>;
> > + default-state = "keep";
> > + };
> > };
> > };
> >
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Attachment:
signature.asc
Description: PGP signature
