Hi Krzysztof,
CC arnd
On Tue, 6 May 2025 at 12:52, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
> On 06/05/2025 12:47, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Enable `CONFIG_STMMAC_ETH` as built-in (`y`) instead of a module (`m`) to
> > ensure the Ethernet driver is available early in the boot process. This
> > is necessary for platforms mounting the root filesystem via NFS, as the
> > driver must be available before the root filesystem is accessed.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Same comments as for previous patches like this (even the same?): you
> are supposed to use initramfs for your arm74 boards. Even armv7 boards
> use initramfs, so network driver does not have to be built in.
Are we? When has that policy changed? Why are lots of network drivers
still built-in? Making network drivers built-in for systems where
development is done using nfsroot has always been acceptable for the
arm64 defconfig before. For things not critical for booting, modular
is indeed the preferred way.
arm64/defconfig is for development and testing, not for production
(which famous kernel developer said that before?)
> For example all of our setups use it thus we do not have to populate all
> other vendors with our own drivers.
>
> Sorry, but I am strongly against such change. Kernel is already way too
The kernel will grow without this (it will just take a few more weeks ;-),
so that is IMHO not a good argument.
> big and with KASAN it does not fit to boot partitions in some of the
> devices (and I cannot change the boot partition size, at least not
> without big effort).
arm64/defconfig does not have KASAN enabled?
> Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Doh...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
