Hi Wolfram, Niklas,
On Mon, 14 Apr 2025 at 12:02, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> This port bypasses the switch and is directly connected to the GMAC.
>
> Co-developed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
> +++ b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
> @@ -15,6 +15,42 @@ / {
> "renesas,r9a06g032";
> };
>
> +&gmac1 {
> + pinctrl-0 = <&pins_eth0>, <&pins_mdio0>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> + phy-mode = "rgmii-id";
> + phy-handle = <&phy_mii0>;
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
> +
> + phy_mii0: ethernet-phy@8 {
> + reg = <8>;
Missing blank line.
> + leds {
> + #address-cells = <1>;
> + #size-cells = <0>;
Likewise.
> + led@0 {
> + reg = <0>;
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_LAN;
> + default-state = "keep";
> + };
> +
> + led@1 {
> + reg = <1>;
> + color = <LED_COLOR_ID_ORANGE>;
> + function = LED_FUNCTION_ACTIVITY;
> + default-state = "keep";
> + };
> + };
> + };
> + };
> +};
LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v6.16 with the above fixed.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
