On Fri, 2 May 2025 at 12:14, Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote:
> Convert the MSIOF I2S driver to reuse the MSIOF register and register
> bit definitions in the header file shared by the MSIOF SPI driver.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> Compile-tested and asm-inspected only due to lack of local sound
> hardware.
> ---
> sound/soc/renesas/rcar/msiof.c | 94 ++++++++++------------------------
> 1 file changed, 28 insertions(+), 66 deletions(-)
>
> diff --git a/sound/soc/renesas/rcar/msiof.c b/sound/soc/renesas/rcar/msiof.c
> index 75c9e91bada10289..36d31ab8ac6a5f18 100644
> --- a/sound/soc/renesas/rcar/msiof.c
> +++ b/sound/soc/renesas/rcar/msiof.c
> @@ -30,56 +30,15 @@
> #include <linux/of_graph.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> +#include <linux/spi/sh_msiof.h>
> #include <sound/dmaengine_pcm.h>
> #include <sound/soc.h>
This needs #include <linux/bitfield.h> on some platforms.
Or better, adding
#include <linux/bitfield.h>
#include <linux/bits.h>
to include/linux/spi/sh_msiof.h in "[PATCH 21/22 ] spi: sh-msiof:
Move register definitions to <linux/spi/sh_msiof.h>", so the header
file becomes fully self-contained.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
