Hi Geert, On Fri, May 2, 2025 at 3:37 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Fri, 2 May 2025 at 14:47, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Change the OSTM driver's probe condition to `CONFIG_ARM64` so that the > > platform driver will defer and reprobe on any ARM64 Renesas SoC once its > > reset controller is available. Previously, only RZ/G2L and RZ/V2H(P) > > were covered. > > > > By matching on `CONFIG_ARM64`, this avoids adding a new config entry > > for each future ARM64 Renesas SoC with OSTM IP. RZ/A1 and RZ/A2 (ARM32) > > are unaffected-they still use OSTM but do not define a resets property, > > so the deferred reprobe mechanism is unnecessary. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > Hi Geert, > > I've restored the Reviewed-by tag from v1 with your suggestions applied. > > I hope you're okay with this. > > Cheers, Prabhakar > > > > v1->v2: > > - Instead of adding config for new SoC, changed the probe condition to > > `CONFIG_ARM64`. > > - Updated commit message > > - Added a Reviewed-by tag from Geert. > > --- > > drivers/clocksource/renesas-ostm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clocksource/renesas-ostm.c b/drivers/clocksource/renesas-ostm.c > > index 3fcbd02b2483..6a5785f9c9c1 100644 > > --- a/drivers/clocksource/renesas-ostm.c > > +++ b/drivers/clocksource/renesas-ostm.c > > @@ -225,7 +225,7 @@ static int __init ostm_init(struct device_node *np) > > > > TIMER_OF_DECLARE(ostm, "renesas,ostm", ostm_init); > > > > -#if defined(CONFIG_ARCH_RZG2L) || defined(CONFIG_ARCH_R9A09G057) > > +#if defined(CONFIG_ARM64) > > Sorry, I've just realized RZ/Five also wants this. > Ouch, I missed that too. > "#ifndef CONFIG_ARM"? > Im wondering will it harm if we have it enabled for ARM too (I dont have RZ/Ax to test it)? Cheers, Prabhakar