Hi Geert, Thank you for the review. On Fri, May 2, 2025 at 1:02 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Thu, 1 May 2025 at 14:37, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Add CONFIG_ARCH_R9A09G056 to the probe condition in renesas-ostm.c so that > > the OSTM platform driver can reprobe for the RZ/V2N (R9A09G056) SoC. Like > > RZ/G2L and RZ/V2H(P), the RZ/V2N contains the Generic Timer Module (OSTM) > > which requires its reset to be deasserted before any register access. > > Enabling the platform_device probe path ensures the driver defers until > > resets are available. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > --- a/drivers/clocksource/renesas-ostm.c > > +++ b/drivers/clocksource/renesas-ostm.c > > @@ -225,7 +225,7 @@ static int __init ostm_init(struct device_node *np) > > > > TIMER_OF_DECLARE(ostm, "renesas,ostm", ostm_init); > > > > -#if defined(CONFIG_ARCH_RZG2L) || defined(CONFIG_ARCH_R9A09G057) > > +#if defined(CONFIG_ARCH_RZG2L) || defined(CONFIG_ARCH_R9A09G057) || defined(CONFIG_ARCH_R9A09G056) > > What about simplifying this to a check for CONFIG_ARM64? > The only SoCs which don't want this are RZ/A1 and RZ/A2, because they > are Cortex-A9 and thus do not have the architectured timer, which is > mandatory on ARM64. > Agreed I will simplify this to CONFIG_ARM64. Cheers, Prabhakar
