Hi Geert, Thank you for the review. On Fri, May 2, 2025 at 12:47 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Tue, 15 Apr 2025 at 10:54, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Add SoC identification for the RZ/V2N SoC using the System Controller > > (SYS) block. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > > Hi All, > > This patch is from series [0]. Since most of the patches have already > > been queued, I'm sending this one separately. > > > > [0] https://lore.kernel.org/all/20250407191628.323613-5-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/ > > Cheers, Prabhakar > > > > v2->v3: > > - Updated dev_info message to include the SoC revision and feature flags. > > - Dropped `<linux/string.h>` include. > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > i.e. will queue in renesas-devel for v6.16... > > > --- /dev/null > > +++ b/drivers/soc/renesas/r9a09g056-sys.c > > > +static void rzv2n_sys_print_id(struct device *dev, > > + void __iomem *sysc_base, > > + struct soc_device_attribute *soc_dev_attr) > > +{ > > + unsigned int part_number; > > + u32 prr_val, mode_val; > > + u8 feature_flags; > > + > > + prr_val = readl(sysc_base + SYS_LSI_PRR); > > + mode_val = readl(sysc_base + SYS_LSI_MODE); > > + > > + /* Check GPU, ISP and Cryptographic configuration */ > > + feature_flags = !(prr_val & SYS_LSI_PRR_GPU_DIS) ? SYS_RZV2N_FEATURE_G31 : 0; > > + feature_flags |= !(prr_val & SYS_LSI_PRR_ISP_DIS) ? SYS_RZV2N_FEATURE_C55 : 0; > > + feature_flags |= (mode_val & SYS_LSI_MODE_SEC_EN) ? SYS_RZV2N_FEATURE_SEC : 0; > > + > > + part_number = 41 + feature_flags; > > + > > + dev_info(dev, "Detected Renesas %s %sn%d Rev %s%s%s%s%s\n", soc_dev_attr->family, > > + soc_dev_attr->soc_id, part_number, soc_dev_attr->revision, feature_flags ? > > + " with" : "", feature_flags & SYS_RZV2N_FEATURE_G31 ? " GE3D (Mali-G31)" : "", > > + feature_flags & SYS_RZV2N_FEATURE_SEC ? " Cryptographic engine" : "", > > + feature_flags & SYS_RZV2N_FEATURE_C55 ? " ISP (Mali-C55)" : ""); > > ... with the above reflowed to avoid splitting ternary expressions, > and with part_number expanded to fill the free space. > Thank you for taking care of this. Cheers, Prabhakar
