Hi, On Wed, Apr 30, 2025 at 3:36 AM Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> wrote: > > Hello Doug, > > On Mon, 28 Apr 2025 13:59:50 -0700 > Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > [...] > > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> # parade-ps8640 > > Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> # parade-ps8640 > > Thank you for your review! > > However I'll be sending v3 with some differences w.r.t. v2, in order to > fix the 3 bugs reported by Andy Yan plus a similar one I spotted. The > fix just is replacing PTR_ERR() with ERR_CAST() in the 4 cases where the > involved function is returning a pointer instead of an int. > > Your review/test tags appear global to the whole patch, thus being the > patch different I think I cannot include your tags in v3. > > Let me know if you think I should do differently. > > Sorry about that. It's fine if you want to drop my tag. I didn't have time to review the whole thing but I felt like I should at least review the drivers I'm signed up as a reviewer for. That being said, I'm not counting tags or anything so I'm not offended if they're dropped. My understanding is that the hashtag at the end is at least a semi-standard way to say that my tag only applies to a small part of the patch, so it seems like it would be OK to carry it, though... -Doug
