On 25/04/25 12:29 am, Luca Ceresoli wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > devm_drm_bridge_alloc() is the new API to be used for allocating (and > partially initializing) a private driver struct embedding a struct > drm_bridge. > > For many drivers having a simple code flow in the probe function, this > commit does a mass conversion automatically with the following semantic > patch. The changes have been reviewed manually for correctness as well as > to find any false positives. > > @@ > type T; > identifier C; > identifier BR; > expression DEV; > expression FUNCS; > @@ > -T *C; > +T *C; > ... > ( > -C = devm_kzalloc(DEV, ...); > -if (!C) > - return -ENOMEM; > +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS); > +if (IS_ERR(C)) > + return PTR_ERR(C); > | > -C = devm_kzalloc(DEV, ...); > -if (!C) > - return ERR_PTR(-ENOMEM); > +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS); > +if (IS_ERR(C)) > + return PTR_ERR(C); > ) > ... > -C->BR.funcs = FUNCS; > > Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> > > --- > > Cc: Adam Ford <aford173@xxxxxxxxx> > Cc: Adrien Grassein <adrien.grassein@xxxxxxxxx> > Cc: Aleksandr Mishin <amishin@xxxxxxxxxx> > Cc: Andy Yan <andy.yan@xxxxxxxxxxxxxx> > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > Cc: Benson Leung <bleung@xxxxxxxxxxxx> > Cc: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Cc: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx> > Cc: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> > Cc: Detlev Casanova <detlev.casanova@xxxxxxxxxxxxx> > Cc: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx> > Cc: Guenter Roeck <groeck@xxxxxxxxxxxx> > Cc: Heiko Stuebner <heiko@xxxxxxxxx> > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > Cc: Janne Grunau <j@xxxxxxxxxx> > Cc: Jerome Brunet <jbrunet@xxxxxxxxxxxx> > Cc: Jesse Van Gavere <jesseevg@xxxxxxxxx> > Cc: Kevin Hilman <khilman@xxxxxxxxxxxx> > Cc: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > Cc: Liu Ying <victor.liu@xxxxxxx> > Cc: Manikandan Muralidharan <manikandan.m@xxxxxxxxxxxxx> > Cc: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx> > Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Cc: Phong LE <ple@xxxxxxxxxxxx> > Cc: Sasha Finkelstein <fnkl.kernel@xxxxxxxxx> > Cc: Sugar Zhang <sugar.zhang@xxxxxxxxxxxxxx> > Cc: Sui Jingfeng <sui.jingfeng@xxxxxxxxx> > Cc: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx> > Cc: Vitalii Mordan <mordan@xxxxxxxxx> > > Changed in v2: > - added missing PTR_ERR() in the second spatch alternative > --- > drivers/gpu/drm/adp/adp-mipi.c | 8 ++++---- > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 ++++----- > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 9 ++++----- > drivers/gpu/drm/bridge/aux-bridge.c | 9 ++++----- > drivers/gpu/drm/bridge/aux-hpd-bridge.c | 9 +++++---- > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 8 ++++---- > drivers/gpu/drm/bridge/chipone-icn6211.c | 9 ++++----- > drivers/gpu/drm/bridge/chrontel-ch7033.c | 8 ++++---- > drivers/gpu/drm/bridge/cros-ec-anx7688.c | 9 ++++----- > drivers/gpu/drm/bridge/fsl-ldb.c | 7 +++---- > drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 9 ++++----- > drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c | 10 ++++------ > drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 8 ++++---- > drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 8 ++++---- > drivers/gpu/drm/bridge/ite-it6263.c | 9 ++++----- > drivers/gpu/drm/bridge/ite-it6505.c | 9 ++++----- > drivers/gpu/drm/bridge/ite-it66121.c | 9 ++++----- > drivers/gpu/drm/bridge/lontium-lt8912b.c | 9 ++++----- > drivers/gpu/drm/bridge/lontium-lt9211.c | 8 +++----- > drivers/gpu/drm/bridge/lontium-lt9611.c | 9 ++++----- > drivers/gpu/drm/bridge/lvds-codec.c | 9 ++++----- > drivers/gpu/drm/bridge/microchip-lvds.c | 8 ++++---- > drivers/gpu/drm/bridge/nwl-dsi.c | 8 ++++---- > drivers/gpu/drm/bridge/parade-ps8622.c | 9 ++++----- > drivers/gpu/drm/bridge/parade-ps8640.c | 9 ++++----- > drivers/gpu/drm/bridge/sii9234.c | 9 ++++----- > drivers/gpu/drm/bridge/sil-sii8620.c | 9 ++++----- > drivers/gpu/drm/bridge/simple-bridge.c | 10 ++++------ > drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 8 ++++---- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 8 ++++---- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi2.c | 8 ++++---- > drivers/gpu/drm/bridge/tc358762.c | 9 ++++----- > drivers/gpu/drm/bridge/tc358764.c | 9 ++++----- > drivers/gpu/drm/bridge/tc358768.c | 9 ++++----- > drivers/gpu/drm/bridge/tc358775.c | 9 ++++----- > drivers/gpu/drm/bridge/thc63lvd1024.c | 8 ++++---- > drivers/gpu/drm/bridge/ti-dlpc3433.c | 9 ++++----- > drivers/gpu/drm/bridge/ti-tdp158.c | 8 ++++---- > drivers/gpu/drm/bridge/ti-tfp410.c | 9 ++++----- > drivers/gpu/drm/bridge/ti-tpd12s015.c | 9 ++++----- > drivers/gpu/drm/mediatek/mtk_dp.c | 9 ++++----- > drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ++++----- > drivers/gpu/drm/mediatek/mtk_dsi.c | 9 ++++----- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 ++++----- > drivers/gpu/drm/meson/meson_encoder_cvbs.c | 12 ++++++------ > drivers/gpu/drm/meson/meson_encoder_dsi.c | 12 ++++++------ > drivers/gpu/drm/meson/meson_encoder_hdmi.c | 12 ++++++------ > drivers/gpu/drm/renesas/rcar-du/rcar_lvds.c | 9 ++++----- > drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 10 ++++------ > 49 files changed, 201 insertions(+), 237 deletions(-) > [...] > diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c > index 1d4ae0097df847d9f93c79eecff0c4587ae331ba..9f4ff82bc6b49010f8727da3b367f5a744a28edc 100644 > --- a/drivers/gpu/drm/bridge/microchip-lvds.c > +++ b/drivers/gpu/drm/bridge/microchip-lvds.c > @@ -157,9 +157,10 @@ static int mchp_lvds_probe(struct platform_device *pdev) > if (!dev->of_node) > return -ENODEV; > > - lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL); > - if (!lvds) > - return -ENOMEM; > + lvds = devm_drm_bridge_alloc(&pdev->dev, struct mchp_lvds, bridge, > + &mchp_lvds_bridge_funcs); > + if (IS_ERR(lvds)) > + return PTR_ERR(lvds); > > lvds->dev = dev; > > @@ -192,7 +193,6 @@ static int mchp_lvds_probe(struct platform_device *pdev) > > lvds->bridge.of_node = dev->of_node; > lvds->bridge.type = DRM_MODE_CONNECTOR_LVDS; > - lvds->bridge.funcs = &mchp_lvds_bridge_funcs; > > dev_set_drvdata(dev, lvds); > ret = devm_pm_runtime_enable(dev); Reviewed-by: Manikandan Muralidharan <manikandan.m@xxxxxxxxxxxxx> -- Thanks and Regards, Manikandan M.
