Hi Tomi,
Thanks for your patch.
On 2025-04-24 10:05:34 +0300, Tomi Valkeinen wrote:
> Remove unnecessary checks wrt. formats and interfaces in rvin_setup().
> The validity of the formats has already been checked earlier.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Tested-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> drivers/media/platform/renesas/rcar-vin/rcar-dma.c | 23 ----------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> index 972ae2cb3314..0b5077e2e989 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> @@ -802,29 +802,6 @@ static int rvin_setup(struct rvin_dev *vin)
> break;
> }
>
> - /* Make sure input interface and input format is valid. */
> - if (vin->info->model == RCAR_GEN3 || vin->info->model == RCAR_GEN4) {
> - switch (vnmc & VNMC_INF_MASK) {
> - case VNMC_INF_YUV8_BT656:
> - case VNMC_INF_YUV10_BT656:
> - case VNMC_INF_YUV16:
> - case VNMC_INF_RGB666:
> - if (vin->is_csi) {
> - vin_err(vin, "Invalid setting in MIPI CSI2\n");
> - return -EINVAL;
> - }
> - break;
> - case VNMC_INF_RAW8:
> - if (!vin->is_csi) {
> - vin_err(vin, "Invalid setting in Digital Pins\n");
> - return -EINVAL;
> - }
> - break;
> - default:
> - break;
> - }
> - }
> -
> /* Enable VSYNC Field Toggle mode after one VSYNC input */
> if (vin->info->model == RCAR_GEN3 || vin->info->model == RCAR_GEN4)
> dmr2 = VNDMR2_FTEV;
>
> --
> 2.43.0
>
--
Kind Regards,
Niklas Söderlund
