On Thu, Apr 24, 2025 at 10:05:49PM +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > The devm lifetime management of this driver is peculiar. The underlying > device for the panel_bridge is the panel, and the devm lifetime is tied the > panel device (panel->dev). However the panel_bridge allocation is not > performed by the panel driver, but rather by a separate entity (typically > the previous bridge in the encoder chain). > > Thus when that separate entoty is destroyed, the panel_bridge is not > removed automatically by devm, so it is rather done explicitly by calling > drm_panel_bridge_remove(). This is the function that does devm_kfree() the > panel_bridge in current code, so update it as well to put the bridge > reference instead. > > Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> This looks fine, but we need a TODO entry to clean this up later on, and a comment on devm_drm_put_bridge that this is inherently unsafe and must not be used. Maxime
Attachment:
signature.asc
Description: PGP signature
