Hi Laurent On Thu, Apr 24, 2025 at 12:14:09AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patches. > > On Tue, Apr 01, 2025 at 04:22:00PM +0200, Jacopo Mondi wrote: > > The VSPX is a VSP2 function that reads data from > > external memory using two RPF instances and feed it to the ISP. > > > > The VSPX includes an IIF unit (ISP InterFace) modeled in the vsp1 driver > > as a new, simple, entity type. > > > > IIF is part of VSPX, a version of the VSP2 IP specialized for ISP > > interfacing. To prepare to support VSPX, support IIF first by > > introducing a new entity and by adjusting the RPF/WPF drivers to > > operate correctly when an IIF is present. > > I think patches 1/5 to 4/5 are ready to be merged, but 5/5 needs more > work. Please let me know if I can take the first four patches in my tree > already. I think so, yes. If we later find out we need to modify anything, we could do that on top, but at the moment I think all changes will be in the VSPX driver itself, which I will re-send separately. Thanks j > > > Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@xxxxxxxxxxxxxxxx> > > --- > > Changes in v7: > > - Include VSPX driver in the series > > - Use existing VSP1 formats and remove patches extending formats on RPF > > - Rework VSPX driver to split jobs creation and scheduling in two > > different API entry points > > - Fix VSPX stride using the user provided bytesperline and using the > > buffer size for ConfigDMA buffers > > - Link to v6: https://lore.kernel.org/r/20250321-v4h-iif-v6-0-361e9043026a@xxxxxxxxxxxxxxxx > > > > Changes in v6: > > - Little cosmetic change as suggested by Laurent > > - Collect tags > > - Link to v5: https://lore.kernel.org/r/20250319-v4h-iif-v5-0-0a10456d792c@xxxxxxxxxxxxxxxx > > > > Changes in v5: > > - Drop additional empty line 5/6 > > - Link to v4: https://lore.kernel.org/r/20250318-v4h-iif-v4-0-10ed4c41c195@xxxxxxxxxxxxxxxx > > > > Changes in v4: > > - Fix SWAP bits for RAW10, RAW12 and RAW16 > > - Link to v3: https://lore.kernel.org/r/20250317-v4h-iif-v3-0-63aab8982b50@xxxxxxxxxxxxxxxx > > > > Changes in v3: > > - Drop 2/6 from v2 > > - Add 5/7 to prepare for a new implementation of 6/7 > > - Individual changelog per patch > > - Add 7/7 > > - Link to v2: https://lore.kernel.org/r/20250224-v4h-iif-v2-0-0305e3c1fe2d@xxxxxxxxxxxxxxxx > > > > Changes in v2: > > - Collect tags > > - Address review comments from Laurent, a lot of tiny changes here and > > there but no major redesign worth an entry in the patchset changelog > > > > --- > > Jacopo Mondi (5): > > media: vsp1: Add support IIF ISP Interface > > media: vsp1: dl: Use singleshot DL for VSPX > > media: vsp1: wpf: Propagate vsp1_rwpf_init_ctrls() > > media: vsp1: rwpf: Support operations with IIF > > media: vsp1: Add VSPX support > > > > drivers/media/platform/renesas/vsp1/Makefile | 3 +- > > drivers/media/platform/renesas/vsp1/vsp1.h | 4 + > > drivers/media/platform/renesas/vsp1/vsp1_dl.c | 7 +- > > drivers/media/platform/renesas/vsp1/vsp1_drv.c | 24 +- > > drivers/media/platform/renesas/vsp1/vsp1_entity.c | 8 + > > drivers/media/platform/renesas/vsp1/vsp1_entity.h | 1 + > > drivers/media/platform/renesas/vsp1/vsp1_iif.c | 121 +++++ > > drivers/media/platform/renesas/vsp1/vsp1_iif.h | 29 ++ > > drivers/media/platform/renesas/vsp1/vsp1_pipe.c | 1 + > > drivers/media/platform/renesas/vsp1/vsp1_pipe.h | 1 + > > drivers/media/platform/renesas/vsp1/vsp1_regs.h | 9 + > > drivers/media/platform/renesas/vsp1/vsp1_rpf.c | 9 +- > > drivers/media/platform/renesas/vsp1/vsp1_vspx.c | 604 ++++++++++++++++++++++ > > drivers/media/platform/renesas/vsp1/vsp1_vspx.h | 86 +++ > > drivers/media/platform/renesas/vsp1/vsp1_wpf.c | 24 +- > > include/media/vsp1.h | 73 +++ > > 16 files changed, 991 insertions(+), 13 deletions(-) > > --- > > base-commit: f2151613e040973c868d28c8b00885dfab69eb75 > > change-id: 20250123-v4h-iif-a1dda640c95d > > -- > Regards, > > Laurent Pinchart
